KAFKA-19822: Remove all unused static classes in Field #20799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Oct 31, 2025
| return set(def.name, value); | ||
| } | ||
|
|
||
| public Struct set(Field.Int64 def, long value) { |
Member
There was a problem hiding this comment.
Could you cleanup the setters as well?
chia7712
reviewed
Nov 1, 2025
| return setIfExists(def.name, value); | ||
| } | ||
|
|
||
| public Struct setIfExists(Field def, Object value) { |
chia7712
approved these changes
Nov 5, 2025
eduwercamacaro
pushed a commit
to littlehorse-enterprises/kafka
that referenced
this pull request
Nov 12, 2025
Remove all unused static classes in `Field`. Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all unused static classes in
Field.Reviewers: Chia-Ping Tsai [email protected]